fix: skip replication to proxy cache project #16286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #16286 +/- ##
==========================================
+ Coverage 67.18% 67.35% +0.17%
==========================================
Files 945 946 +1
Lines 78191 78660 +469
Branches 2315 2315
==========================================
+ Hits 52536 52985 +449
- Misses 22143 22163 +20
Partials 3512 3512
Flags with carried forward coverage won't be shown. Click here to find out more.
|
chlins
force-pushed
the
fix/skip-replication-for-proxy-cache
branch
from
f36fc58
to
6a99261
Compare
chlins
force-pushed
the
fix/skip-replication-for-proxy-cache
branch
from
6a99261
to
f514784
Compare
wy65701436
reviewed
Jan 26, 2022
wy65701436
reviewed
Jan 26, 2022
| @@ -182,9 +182,14 @@ func (a *Adapter) PrepareForPush(resources []*model.Resource) error { | |||
| return errors.Wrapf(err, "list projects with query %s", q) | |||
| } | |||
|
|
|||
| proxyCacheProjects := make(map[string]*Project) | |||
There was a problem hiding this comment.
make(map[string]bool) is enough?
wy65701436
reviewed
Jan 26, 2022
wy65701436
reviewed
Jan 26, 2022
wy65701436
reviewed
Jan 26, 2022
Signed-off-by: chlins <chenyuzh@vmware.com>
chlins
force-pushed
the
fix/skip-replication-for-proxy-cache
branch
from
f514784
to
b1afd2e
Compare
stonezdj
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15155
Signed-off-by: chlins chenyuzh@vmware.com